Don't warn that models aren't available if Flax is available. #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
reviewed
Nov 30, 2020
src/transformers/__init__.py
Outdated
| @@ -892,7 +892,7 @@ | |||
| from .utils.dummy_flax_objects import * | |||
|
|
|||
|
|
|||
| if not is_tf_available() and not is_torch_available(): | |||
| if not is_tf_available() and not is_torch_available() and not is_flax_available(): | |||
| logger.warning( | |||
| "Neither PyTorch nor TensorFlow >= 2.0 have been found. " | |||
There was a problem hiding this comment.
Could we also add flax in the warning? I don't think it would do any harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disables the "Neither PyTorch nor TensorFlow >= 2.0 have been found" warning if Flax has been found.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.