Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #8837
What does this PR do?
Updating the PreTrainedTokenizerBase.pad argument default value docstring to show the correct default value.
Current
docstring:
transformers/src/transformers/tokenization_utils_base.py
Lines 2469 to 2470 in d5b3e56
arg:
transformers/src/transformers/tokenization_utils_base.py
Lines 2431 to 2472 in d5b3e56
Fixes #8837 (issue)
I'm also curious why this method has default
padding=True
? Other methods (prepare_for_model, encode, call, encode_plus, batch_encode_plus) havepadding=False
.Its default means the DataCollatorForLanguageModeling pads input examples which means it can't be simply switched with the default collator in the example script without breaking the attention mask.
transformers/src/transformers/data/data_collator.py
Line 253 in 610cb10
@mfuntowicz
@LysandreJik
@sgugger