Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interaction of return_token_type_ids and add_special_tokens #8854

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix interaction of return_token_type_ids and add_special_tokens #8854

merged 1 commit into from
Dec 8, 2020

Conversation

LysandreJik
Copy link
Member

Fix #8578

It shouldn't raise a warning if return_token_type_ids is set to False. @thomwolf am I missing something here?

@LysandreJik LysandreJik mentioned this pull request Nov 30, 2020
Closed
@LysandreJik LysandreJik merged commit b7cdd00 into master Dec 8, 2020
@LysandreJik LysandreJik deleted the add-special-tokens_return-token-type-ids_fix branch December 8, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwolf thomwolf Awaiting requested review from thomwolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Asking to return token_type_ids while setting add_special_tokens to False
1 participant
@LysandreJik