Prevent BatchEncoding from blindly passing casts down to the tensors it contains #8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Dec 1, 2020
…it contains. Fixes huggingface#6582. Update src/transformers/tokenization_utils_base.py with review fix Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Craigacp
force-pushed
the
batch-encoding-cast-check
branch
from
d35f6f6
to
2a33400
Compare
|
black complained about the style after the update, so I fixed it and squashed the commits again. |
|
Thank you @Craigacp! |
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Dec 5, 2020
…it contains. Fixes huggingface#6582. (huggingface#8860) Update src/transformers/tokenization_utils_base.py with review fix Co-authored-by: Lysandre Debut <lysandre@huggingface.co> Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR prevents
BatchEncoding.tofrom passing down things which aren't devices to the tensors it contains. Previously it would pass down all the arguments, and as thetomethod in pytorch can also cast the arguments to different types it's used blindly by other packages (e.g. Nvidia's Apex). This caused an issue where when using Apex's AMP support withO2or greater it would cast the token indexes from aLongTensorto aHalfTensortruncating our vocab at 65k and rounding most of the words to the nearest 8th word (if you blindly insert the cast back in in the embedding layer, which the warning says to do).The doc for
BatchEncoding.tosays it is only for moving the encoding and the tensors it contains between devices, but as the type checking isn't on by default it can behave like a regular pytorchtomethod and accept cast arguments that it passes down to the tensors it contains.Fixes #6582
Before submitting
Pull Request section?
to it if that's the case. BatchEncoding interacts poorly with apex.amp #6582
documentation guidelines, and
here are tips on formatting docstrings.
There are no docs or tests changes as the change makes the method conform with its currently documented behaviour.
@LysandreJik