Transfoxl seq classification #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
LGTM, thanks a lot @spatil6!
Same as GPT-2, this would benefit from also handling padding on the left; I'll work on this in another PR.
sgugger
approved these changes
Dec 1, 2020
| @@ -632,6 +633,40 @@ class TransfoXLModelOutput(ModelOutput): | |||
| attentions: Optional[Tuple[torch.FloatTensor]] = None | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class TransfoXLSequenceClassifierOutputWithPast(ModelOutput): | |||
There was a problem hiding this comment.
This new class needs to be documented in the .rst with the other TransfoXL-specific outputs.
| batch_size, sequence_length = inputs_embeds.shape[:2] | ||
|
|
||
| assert ( | ||
| self.config.pad_token_id is not None or batch_size == 1 |
patrickvonplaten
approved these changes
Dec 1, 2020
LysandreJik
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Sequence classification for Transformer XL model
TransfoxlForSequenceClassification uses the last token in order to do the classification, as other causal models (e.g. GPT-1,GPT-2) do.
Fixes #7623 (Partially)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@LysandreJik