Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trainer] start using training_args.parallel_mode #8882

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Dec 1, 2020

Following up on #8877 which adds training_args.parallel_mode to make it easy to comprehend which mode the trainer is running under - this PR deploys the new property in a few places.

@sgugger, have I deployed it as you envisioned it?

@stas00 stas00 requested a review from sgugger December 1, 2020 19:22
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is clearer and easier to understand!
Thanks!

@stas00 stas00 merged commit 379005c into huggingface:master Dec 1, 2020
@stas00 stas00 deleted the parallel_mode branch December 1, 2020 19:40
@stas00
Copy link
Contributor Author

stas00 commented Dec 1, 2020

Thank you for adding this new property, @sgugger - it has indeed improved the readability!

stas00 added a commit to stas00/transformers that referenced this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants