Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak wording + Add badge w/ number of models on the hub #8914

Merged
merged 5 commits into from
Dec 3, 2020

Conversation

julien-c
Copy link
Member

@julien-c julien-c commented Dec 3, 2020

it seemed pertinent to display this here but maybe we can also add it to some other places

@julien-c
Copy link
Member Author

julien-c commented Dec 3, 2020

[Tooling comment] For some reason python utils/check_copies.py --fix_and_overwrite fails on my Python with following:

(.env) ipro:transformers gibbon$ python utils/check_copies.py --fix_and_overwrite
Traceback (most recent call last):
  File "utils/check_copies.py", line 432, in <module>
    check_model_table(args.fix_and_overwrite)
  File "utils/check_copies.py", line 414, in check_model_table
    new_table = get_model_table_from_auto_modules()
  File "utils/check_copies.py", line 328, in get_model_table_from_auto_modules
    spec = importlib.util.spec_from_file_location(
AttributeError: module 'importlib' has no attribute 'util'

@sgugger
Copy link
Collaborator

sgugger commented Dec 3, 2020

I think it's better at the top rather than the end of the list (I don't think a user will read to until the end of the list TBH). We could even put it further up the README!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LysandreJik LysandreJik merged commit 9ad6194 into master Dec 3, 2020
@LysandreJik LysandreJik deleted the hub_badge branch December 3, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants