Use word_ids to get labels in run_ner #8962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As #8958 pointed out, the current way labels are computed in the
run_ner
script using offset mappings does not work for sentencepiece-based tokenizers. This PR fixes that using the.word_ids
method which is more elegant and more reliable.In passing it adds an early check that the tokenzier is fast (otherwise the script just doesn't work).
Fixes #8958