Removed unused encoder_hidden_states and encoder_attention_mask
#8972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LysandreJik I had to remove some tests that were testing the decoder mode for MobileBert. One test still fails (flax), the error seems unrelated to this PR unless I am missing something? |
LysandreJik
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
This LGTM, it doesn't remove any supported behavior. @patrickvonplaten what do you think?
patrickvonplaten
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes unused
encoder_hidden_statesandencoder_attention_maskfrom MobileBert forward methods. These are use for decoder models, but MobileBert does not include a cross-attention mechanism.Fixes #8969
Who can review?
albert, bert, XLM: @LysandreJik