Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix to the run clm script #8973

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Small fix to the run clm script #8973

merged 1 commit into from
Dec 7, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Dec 7, 2020

What does this PR do?

@LysandreJik pointed out that the scripts will fail with a cryptic error if the tokenizer model_max_len is huge and no block_size is set. This PR fixes this by clipping the block_size to 1024 (when no value is passed).

LysandreJik
LysandreJik approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@sgugger sgugger merged commit 62d30e0 into master Dec 7, 2020
@sgugger sgugger deleted the run_clm_fixes branch December 7, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgugger @LysandreJik