Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI doc] safely testing experimental CI features #9070

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Dec 11, 2020

After causing a few CI workflow disruptions with my recent attempts to figure out how to get circleCI do something new (skip heavy builds on doc-only PRs) I realized that future such experiments can be much smoother and lead to close to zero annoyance to anybody involved in submitting and handling PRs.

This PR documents my idea on how to do it given the current limitations of CircleCI and GithubActions, so that we could continue doing such experiments in the future and not interfere with anything.

That's said please vote here:

to get a much simpler support for being able to have a failing step that shouldn't impact the overall PR status.

@LysandreJik, @sgugger

@stas00 stas00 changed the title [CI] Testing Experimental CI Features [CI doc] safely testing experimental CI features Dec 11, 2020
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice explanation, I think you explained the issue well and your proposal makes sense. Thanks, LGTM.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thanks for all your work on this topic!

@LysandreJik LysandreJik merged commit b00eb4f into huggingface:master Dec 14, 2020
@stas00 stas00 deleted the testing-on-ci branch December 14, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants