Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify use of TrainingArguments.disable_tqdm in Jupyter Notebooks #9076

Merged
merged 20 commits into from
Dec 15, 2020
Merged

Clarify use of TrainingArguments.disable_tqdm in Jupyter Notebooks #9076

merged 20 commits into from
Dec 15, 2020

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Dec 12, 2020

What does this PR do?

Closes #8831 and adds some minor tweaks / improvements to the TrainingArguments classes.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@sgugger

sgugger
sgugger approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this is looking great to me. Just have a few more corrections suggested.

src/transformers/training_args.py Outdated Show resolved Hide resolved
src/transformers/training_args.py Outdated Show resolved Hide resolved
src/transformers/training_args.py Outdated Show resolved Hide resolved
src/transformers/training_args_tf.py Outdated Show resolved Hide resolved
src/transformers/training_args_tf.py Outdated Show resolved Hide resolved
lewtun and others added 6 commits December 15, 2020 10:11
@lewtun @sgugger
Fix underscore in weblink
c4c4a96 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@lewtun @sgugger
Fix underscore in weblink
535dac2 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@lewtun @sgugger
Fix underscore in weblink
801014e 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@lewtun @sgugger
Fix underscore in weblink
3673f76 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@lewtun @sgugger
Add obj to datasets.Dataset
582e64a 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@lewtun
Merge branch 'master' into clarify-trainer-logging
fe11879
@lewtun
Copy link
Member Author

lewtun commented Dec 15, 2020

Thanks for the suggestions! I've included them so should be good to go :)

@sgugger sgugger merged commit ed1845e into huggingface:master Dec 15, 2020
@sgugger
Copy link
Collaborator

sgugger commented Dec 15, 2020

Thanks a lot!

@lewtun lewtun deleted the clarify-trainer-logging branch December 16, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging.set_verbosity_error() displays dict instead of NotebookTrainingTracker
2 participants
@lewtun @sgugger