Fix tf2.4 #9120
Fix tf2.4 #9120
Conversation
tests/test_optimization_tf.py
Outdated
| @@ -76,12 +76,12 @@ def accumulate(grad1, grad2): | |||
| local_variables = strategy.experimental_local_results(gradient_placeholder) | |||
| local_variables[0].assign(grad1) | |||
| local_variables[1].assign(grad2) | |||
| strategy.experimental_run_v2(accumulate_on_replica, args=(gradient_placeholder,)) | |||
| strategy.run(accumulate_on_replica, args=(gradient_placeholder,)) | |||
There was a problem hiding this comment.
I'm confused, if the strategy was just removed from experimental, how is this going to be compatible with versions <2.4?
There was a problem hiding this comment.
The run method is not experimental anymore since the TF 2.2 release, and removed of the experimental namespace since the 2.4.
There was a problem hiding this comment.
Ok but we are pinned to is >=2.0
There was a problem hiding this comment.
Yep, at some point if we want to keep improve the TF codebase we have to change this sometime, this will be soon the case with the upcoming perf improvements. We will have to move to at least 2.3.
There was a problem hiding this comment.
I understand, but unless that move happens today, we need some code that deals with both versions here.
There was a problem hiding this comment.
like this? (just pushed an update)
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
|
LGTM! |
What does this PR do?
Fix the tests to make them compliant with the new TF 2.4