Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF Transfo XL #9129

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Fix TF Transfo XL #9129

merged 1 commit into from
Dec 15, 2020

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Dec 15, 2020

What does this PR do?

This PR fixes an issue in TFTransfoXL the last layer was added into the complete list of hidden_states while being already transposed. Then adding it at the end after all the other states have been transposed.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LysandreJik LysandreJik merged commit e771749 into huggingface:master Dec 15, 2020
@jplu jplu deleted the fix-tf-transfoxl branch December 15, 2020 21:20
guyrosin pushed a commit to guyrosin/transformers that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants