Update notebook table and transformers intro notebook #9136
Conversation
| @@ -89,13 +91,12 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "!pip install transformers\n", | |||
| "!pip install --upgrade tensorflow" | |||
| "# !pip install transformers" | |||
There was a problem hiding this comment.
I think it's worth it to pin transformers to the current version since we don't test the notebooks -> !pip install transformers==4.0.0 . Wdyt?
There was a problem hiding this comment.
The goal is still to have those work on the latest release. I'm afraid the pinning will be forever left there afterward and the notebook will never be updated.
There was a problem hiding this comment.
hmm, yeah, can we add a test to make sure the notebooks always work with the latest version? I'm a bit worried that we'll just forget to update the notebook and it doesn't work which will churn away many users
There was a problem hiding this comment.
The problem is most of the notebooks all have a big training, which takes too long to run. It's easy to have something that execute a given notebook, but if we have to skip some cells because of the time it takes, we usually can't execute the cells after.
So we can automate testing on those that take not too long (might require a machine with a GPU) but not the bigger ones.
|
Discussion on pinning/testing notebooks needs to be global on all notebooks (not just one) so merging this for now. We can think of a strategy and implement it in a follow-up PR. |
What does this PR do?
Update the examples table and the notebooks table to include all recent examples. Also fix the intro notebook to the transformers library, in particular, the image that was missing.
Fixes #9083