Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to documentation that longformer doesn't support token_type_ids #9152

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Add message to documentation that longformer doesn't support token_type_ids #9152

merged 2 commits into from
Dec 16, 2020

Conversation

HHousen
Copy link
Contributor

@HHousen HHousen commented Dec 16, 2020

What does this PR do?

Fixes #9111. This pull request adds a notice to the Longformer model documentation that it does not have token_type_ids, similarly to the message on the RoBERTa documentation.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@sgugger (documentation)
@patrickvonplaten (longformer)

@sgugger
Copy link
Collaborator

sgugger commented Dec 16, 2020

Thanks for your PR! It looks like you did not run the make style command to format properly your changes.

@HHousen
Copy link
Contributor Author

HHousen commented Dec 16, 2020

@sgugger Sorry about that. It should be good now.

@sgugger
Copy link
Collaborator

sgugger commented Dec 16, 2020

Thanks a lot!

@sgugger sgugger merged commit 3433466 into huggingface:master Dec 16, 2020
@HHousen HHousen deleted the HHousen/longformer-token-type-ids branch December 16, 2020 16:29
guyrosin pushed a commit to guyrosin/transformers that referenced this pull request Jan 15, 2021
…pe_ids (huggingface#9152)

* Add message to documentation that longformer doesn't support token_type_ids

* Format changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longformer token_type_ids Vocabulary Size is 1 But Documentation States Otherwise
2 participants