Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lm_head decoder bias warning #9615

Merged
merged 3 commits into from Jan 15, 2021

Conversation

LysandreJik
Copy link
Member

Removes the warning that's currently happening when importing xlm-roberta-base with any of the XLM-R models.

Closes #9579

@sgugger
Copy link
Collaborator

sgugger commented Jan 15, 2021

Is it normal that this bias is missing?

@LysandreJik
Copy link
Member Author

By answering your question I realized this could be upstreamed directly in the RoBERTa model, which I just did.

You can take a look at my answer this morning to a similar question: #6193 (comment).

XLM-R is an alias of the RoBERTa model, hence why they both need this.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes making the changes in the source class is more efficient (and better).

@LysandreJik LysandreJik merged commit 6d3b688 into master Jan 15, 2021
@LysandreJik LysandreJik deleted the xlm-roberta-base-weight-initializer branch January 15, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants