wp-graphql#156-options-queries

Updates to tests and making sure the option is cast as the proper type when it's returned

src/Data/DataSource.php

@@ -45,10 +45,16 @@ class DataSource {
 	 * See: https://developer.wordpress.org/reference/functions/register_setting/
 	 *
 	 * @var array $allowed_setting_types
-	 * @access public
+	 * @access protected
 	 */
-	public static $allowed_setting_types;
+	protected static $allowed_setting_types;
 
+	/**
+	 * Stores an array of allowed setting groups.
+	 *
+	 * @var array $allowed_setting_groups
+	 * @access protected
+	 */
 	protected static $allowed_setting_groups;
 
 	/**

src/Type/Setting/SettingType.php

@@ -22,25 +22,33 @@ class SettingType extends WPObjectType {
 	/**
 	 * Holds the $fields definition for the SettingType
 	 *
-	 * @var $fields
+	 * @var array $fields
+	 * @access private
 	 */
 	private static $fields;
 
 	/**
 	 * Holds the $setting_type definition
+	 *
+	 * @var string $setting_type
+	 * @access private
 	 */
 	private static $setting_type;
 
 	/**
 	 * Holds the $setting_type_array definition which contains
 	 * all of the settings for the given setting_type
+	 *
+	 * @var array $setting_fields
+	 * @access private
 	 */
 	private static $setting_fields;
 
 	/**
 	 * SettingType constructor.
 	 *
 	 * @param string $setting_type The setting group name
+	 * @access public
 	 */
 	public function __construct( $setting_type ) {
 
@@ -114,6 +122,7 @@ private static function fields( $setting_fields, $group ) {
 						'type'        => Types::get_type( $setting_field['type'] ),
 						'description' => $setting_field['description'],
 						'resolve'     => function( $root, $args, AppContext $context, ResolveInfo $info ) use ( $setting_field, $field_key, $key ) {
+
 							/**
 							 * Check to see if the user querying the email field has the 'manage_options' capability
 							 * All other options should be public by default
@@ -125,6 +134,7 @@ private static function fields( $setting_fields, $group ) {
 							}
 
 							$option = ! empty( $setting_field['key'] ) ? get_option( $setting_field['key'] ) : null;
+
 							switch ( $setting_field['type'] ) {
 								case 'integer':
 									$option = absint( $option );

tests/test-setting-queries.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * WPGraphQL Test generalSetting Queries
  *
@@ -237,7 +236,7 @@ public function testDiscussionSettingQuery() {
 		 * Validate the request
 		 */
 		wp_set_current_user( $this->admin );
-	
+
 		update_option( 'default_comment_status', 'test_value' );
 		update_option( 'default_ping_status', 'test_value' );