Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests for mediaItems #156

Closed
jasonbahl opened this issue Jun 23, 2017 · 2 comments
Closed

Unit Tests for mediaItems #156

jasonbahl opened this issue Jun 23, 2017 · 2 comments
Assignees
@hughdevore
Labels
scope: tests Status: In Review Needs to be reviewed by a project maintainer before merge
Milestone
1.0 release

Comments

@jasonbahl
Copy link
Collaborator

I wrote some mediaItems tests using introspection queries, but the way I wrote them were kind of silly.

Need to rewrite them
@jasonbahl jasonbahl mentioned this issue Jun 23, 2017
Merged
@jasonbahl jasonbahl added this to the 1.0 release milestone Jul 26, 2017
@hughdevore hughdevore self-assigned this Sep 28, 2017
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 2, 2017
@hughdevore
wp-graphql#156 Finishing tests for mediaItemCreate.
3dd69dd
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 4, 2017
@hughdevore
wp-graphql#156 Finished all mediaItem tests.
70fbfdb
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 4, 2017
@hughdevore
wp-graphql#156 Adding coverage directory to gitignore.
a822a56
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 4, 2017
@hughdevore
wp-graphql#156 Removing coverage directory.
976956d
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 4, 2017
@hughdevore
wp-graphql#156 Adding empty coverage directory and gitignore.
7236481
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Cleaning up code and formatting.
497c2f7
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Fixing merge conflict.
9e75f9b
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Adding mediaItem full test coverage.
35b41c3
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Initial commit.
a29603c
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Moving testCreateMediaItemWithNoFile to fix merge conf…
9126dcc 
…lict.
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Moving testCreateMediaItemDefaultValues to fix merge c…
1bbeaf6 
…onflict.
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Moving testCreateMediaItemWithInvalidUrl to fix merge …
584ae31 
…conflict.
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Finishing mediaItem code coverage.
d9fb8b0
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Cleaning up assertion.
b11b2b7
@coveralls coveralls mentioned this issue Oct 5, 2017
Merged
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Adding mediaItemCreate assertion.
ad35212
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 5, 2017
@hughdevore
wp-graphql#156 Updating createMediaItem validation.
9fa09a2
jasonbahl added a commit that referenced this issue Oct 5, 2017
@jasonbahl
Merge pull request #241 from hughdevore/tests/#156-media-items
3c40346 
#156 Finishing mediaItem code coverage.
@CodeProKid CodeProKid added the Status: In Review Needs to be reviewed by a project maintainer before merge label Oct 10, 2017
@CodeProKid
Copy link
Member

Pretty sure this can be closed?

@jasonbahl
Copy link
Collaborator Author

@CodeProKid yes it can

hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 10, 2017
@hughdevore
wp-graphql#156 Adding general setting queries.
40095f6
This was referenced Oct 10, 2017
Closed
Merged
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 18, 2017
@hughdevore
Merge remote-tracking branch 'upstream/develop' into features/wp-grap…
849b995 
…hql#156-optionsQueries
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Oct 18, 2017
@hughdevore
Merge remote-tracking branch 'upstream/develop' into features/wp-grap…
67b02ea 
…hql#156-optionsQueries
jasonbahl added a commit to jasonbahl/wp-graphql that referenced this issue Oct 27, 2017
@jasonbahl
Merge branch 'develop' into features/wp-graphql#156-optionsQueries
f1f41d5 
# Conflicts:
#	src/Types.php
jasonbahl added a commit to jasonbahl/wp-graphql that referenced this issue Oct 27, 2017
@jasonbahl
wp-graphql#156 - OptionsQueries - Misc updates
9af44b2
jasonbahl added a commit to jasonbahl/wp-graphql that referenced this issue Oct 27, 2017
@jasonbahl
wp-graphql#156-options-queries
b745a59 
Updates to tests and making sure the option is cast as the proper type when it's returned
jasonbahl added a commit to hughdevore/wp-graphql that referenced this issue Oct 27, 2017
@jasonbahl
wp-graphql#156-options-queries
1195c90 
Updates to tests and making sure the option is cast as the proper type when it's returned
jasonbahl added a commit to hughdevore/wp-graphql that referenced this issue Oct 27, 2017
@jasonbahl
wp-graphql#156-options-queries
7bdc36a 
Updates to tests and making sure the option is cast as the proper type when it's returned
jasonbahl added a commit that referenced this issue Oct 27, 2017
@jasonbahl
Merge pull request #277 from hughdevore/features/#156-optionsQueries
c7309ce 
Features/#156 - Adding Settings queries
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Nov 7, 2017
@hughdevore
wp-graphql#156 Adding initial mutation files.
b33d703
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Nov 15, 2017
@hughdevore
Merge remote-tracking branch 'upstream/develop' into features/wp-grap…
191f37c 
…hql#156-optionsMutations
@coveralls coveralls mentioned this issue Nov 15, 2017
Merged
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Nov 16, 2017
@hughdevore
Merge remote-tracking branch 'upstream/develop' into features/wp-grap…
8b6e0a6 
…hql#156-optionsMutations
hughdevore added a commit to hughdevore/wp-graphql that referenced this issue Nov 16, 2017
@hughdevore
Merge remote-tracking branch 'upstream/develop' into features/wp-grap…
b75686a 
…hql#156-optionsMutations
jasonbahl added a commit that referenced this issue Dec 7, 2017
@jasonbahl
Merge pull request #312 from hughdevore/features/#156-optionsMutations
8d2e849 
Features/#156 options mutations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hughdevore hughdevore

Labels
scope: tests Status: In Review Needs to be reviewed by a project maintainer before merge
Projects
None yet
Milestone
1.0 release
Development

No branches or pull requests
3 participants
@jasonbahl @CodeProKid @hughdevore