Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd causing issues with devices sharing chip #275

Closed
TheOnlyJoey opened this issue Oct 11, 2017 · 2 comments
Closed

fwupd causing issues with devices sharing chip #275

TheOnlyJoey opened this issue Oct 11, 2017 · 2 comments

Comments

@TheOnlyJoey
Copy link

In this case devices with 0483:5750 STMicroelectronics chips will be claimed by fwupd and get stuck in a error state.
fwupd should check the usb descriptor to see if it is actually the right device, since chips can be re-used for multiple devices (this one being use in the Deepoon E2, NOLO CV1 and to name 2) while being claimed for a 8bitdo controller.

More information in the original bugreport: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1717009

@hughsie
Copy link
Member

hughsie commented Oct 12, 2017

Do you know what part of the USB descriptor can be compared? Would you like to have a go at a patch to fix this? I'm happy to help as much as required.

@TheOnlyJoey
Copy link
Author

Well the manufacturer and product string would be sufficient, we do this exact check in OpenHMD as well.
This example is using a check for exact this same chip: https://github.com/OpenHMD/OpenHMD/blob/master/src/drv_deepoon/deepoon.c#L294 (using hid descriptors but USB has this information as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants