Admin user management #1330
Merged
Admin user management #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ALLOW_UNCONFIRMED_ACCESS_FOR=2.days | ||
|
|
||
| # Duration for which the confirmation token is valid | ||
| CONFIRM_WITHIN=3.days |
|
Awesome! @TildeWill will appreciate this for his hosting efforts. |
|
I'm pretty excited, user management has always felt missing to me. |
dsander
force-pushed
the
feature/user-admin-interface
branch
from
322fc74
to
df349a7
Compare
|
@TildeWill @cantino Would you mind giving it another look? I think I incorporated your feedback. |
|
@dsander thanks for the migration. This will be a big help! |
|
Awesome, I'll take another look at this and your other files PR in the next couple days. (Sorry, very busy right now.) I really appreciate all the work you're putting into these! |
|
@cantino No problem, family and work always comes first 😄 |
| @@ -172,4 +172,27 @@ | |||
| expect(tuples).to eq expected | |||
| end | |||
| end | |||
|
|
|||
| context "#parse_duration" do | |||
There was a problem hiding this comment.
I'd recommend adding a spec for the positive cases too.
expect(Utils.parse_duration('2.days')).to eq(2.days)
expect(Utils.parse_duration('2.seconds')).to eq(2)
expect(Utils.parse_duration('2')).to eq(2)
|
Awesome work! |
dsander
force-pushed
the
feature/user-admin-interface
branch
2 times, most recently
from
7d470bf
to
c2d74cd
Compare
dsander
force-pushed
the
feature/user-admin-interface
branch
from
d7fdb2c
to
c0c7411
Compare
|
Thanks for the reviews and feedback! @cantino @knu @TildeWill |
|
:)
|
|
Just merged this into my fork and deployed, so awesome! I can see at a glance how people are using the site. Thanks @dsander!!! |
|
@TildeWill Glad you like it 😄 |
|
This PR breaks in Heroku 😭 |
|
You need to run |
|
Solved!! |
kamipo
added a commit
to rails/rails
that referenced
this pull request
Feb 21, 2019
…collation issues In MySQL, the default collation is case insensitive. Since the uniqueness validator enforces case sensitive comparison by default, it frequently causes mismatched collation issues (performance, weird behavior, etc) to MySQL users. https://grosser.it/2009/12/11/validates_uniqness_of-mysql-slow/ #1399 #13465 gitlabhq/gitlabhq@c1dddf8 huginn/huginn#1330 (comment) This extracts `default_uniqueness_comparison` to ease to handle the mismatched collation issues on the connection.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Mar 4, 2019
In MySQL, the default collation is case insensitive. Since the uniqueness validator enforces case sensitive comparison by default, it frequently causes mismatched collation issues (performance, weird behavior, etc) to MySQL users. https://grosser.it/2009/12/11/validates_uniqness_of-mysql-slow/ rails#1399 rails#13465 gitlabhq/gitlabhq@c1dddf8 huginn/huginn#1330 (comment) I'd like to deprecate the implicit default enforcing since I frequently experienced the problems in code reviews. Note that this change has no effect to sqlite3, postgresql, and oracle-enhanced adapters which are implemented as case sensitive by default, only affect to mysql2 adapter (I can take a work if sqlserver adapter will support Rails 6.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic user management interface. Admins can create and edit users, additionally user accounts can be deactivated which also stops their agents from running. The deactivation works independently from the devise account locking.
Many of the devise configuration options are now accessible via the
.envfile.#371
#1121
Thanks to kreuzwerker.de who are paying me to work on this in the context of the research project 'Digitale Kuratierungstechnologien' of which they are a part of.