Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions on how to use the theme as hugo module #169

Merged
merged 1 commit into from Mar 10, 2024
Merged

Add instructions on how to use the theme as hugo module #169

merged 1 commit into from Mar 10, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Mar 4, 2024

What problem does this PR solve?

This PR adds instructions on how to use the theme as hugo module.
It also renames config.toml to hugo.toml in various places.

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

@github-actions github-actions bot added the size/m label Mar 4, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2024 •
edited

✅ Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 77996bd
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/65ec984092c1cf0008d4c075
😎 Deploy Preview https://deploy-preview-169--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@deining deining force-pushed the hugo-module branch 3 times, most recently from eb92082 to eec887e Compare March 4, 2024 20:43
@github-actions github-actions bot added the conflicts This PR has conflicts which must be resolved before it can be reviewed. label Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

This pull request has conflicts with the base branch, please resolve those so that we can review the pull request.

@github-actions github-actions bot removed the conflicts This PR has conflicts which must be resolved before it can be reviewed. label Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Conflicts have been resolved! 🎉 A maintainer will soon review the pull request.

@deining
Copy link
Contributor Author

deining commented Mar 7, 2024

Rebased the PR and resolved merge conflicts.
I realised that preview of my PR is fine with hugo 0.122.0, but fails with hugo 0.123.7.
I doubt that 9f042a8 was a complete fix for the issue addressed in #170.

@MichielVanDerWinden
Copy link
Contributor

Just to mention it here as well - the go.sum still points at release v1.13.0 that doesn't contain the fix yet. When a new release has been created, it can be used as a go module and will resolve the issue.

@deining
Copy link
Contributor Author

deining commented Mar 7, 2024

the go.sum still points at release v1.13.0 that doesn't contain the fix yet.

You are right. I just changed go.sum to point to HEADof repo and everything is fine now 😄.
Sorry for the noise!

hugo-sid
hugo-sid reviewed Mar 7, 2024
View reviewed changes
exampleSite/go.mod Outdated Show resolved Hide resolved
hugo-sid
hugo-sid requested changes Mar 7, 2024
View reviewed changes
Copy link
Owner

@hugo-sid hugo-sid left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deining, thanks again for taking time to improve this theme.

I have mentioned few queries and a request to upgrade Hugo version used on Netlify.

Please feel free to let me know, if something is not clear.

exampleSite/hugo.toml Show resolved Hide resolved
netlify.toml Show resolved Hide resolved
@deining deining requested a review from hugo-sid March 7, 2024 22:02
@deining deining force-pushed the hugo-module branch 2 times, most recently from 86c4378 to 51c0e6b Compare March 9, 2024 17:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

hugo-sid
hugo-sid approved these changes Mar 10, 2024
View reviewed changes
Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you for Andreas, enabling support for Hugo modules.

Also, a big thank you, for your numerous contributions to this theme.

@hugo-sid hugo-sid merged commit 3356999 into hugo-sid:main Mar 10, 2024
7 checks passed
@hugo-sid hugo-sid mentioned this pull request Mar 7, 2024
Merged
@deining deining deleted the hugo-module branch March 10, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-sid hugo-sid hugo-sid approved these changes

Assignees
No one assigned
Labels
size/m
Projects
Hugo blog awesome progress tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deining @MichielVanDerWinden @hugo-sid