Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get embed-pdf to work #842

Closed
2 of 6 tasks
MarionMoseby opened this issue Dec 5, 2023 · 1 comment · Fixed by #844
Closed
2 of 6 tasks

Can't get embed-pdf to work #842

MarionMoseby opened this issue Dec 5, 2023 · 1 comment · Fixed by #844

Comments

@MarionMoseby
Copy link
Contributor

MarionMoseby commented Dec 5, 2023

Expected Behavior

Hi! I have been updating my (pretty huge) personal website, pablomarcos.me (link to the repo), to the new, npm-using, hugo-mod version of toha. I have managed to make everything work pretty easily (kudos!) but I just cant seem to make the embed-pdf shortcode to work.

Current Behavior

I see that search works on toha-guides.github.io, but not on my site; there are no examples of embed-pdf on toha-guides.

I dont have much custom layouts, or anything that I can think of that would interfere with this two functions, so, after some looking at the code, I thought I would ask to see if anyone could reproduce the issue.

Possible Solution

Note that I added a copy of the old embed-pdf layout to my repo just to have it working; but, where I to remove it, the div is kept loading. Maybe there is a change on the way the shortcode should be used?

Steps to Reproduce

  1. Go to https://codeberg.org/FlyingFlamingo/pablomarcos-me
  2. Clone repo, remove layouts/shortcodes/embed-pdf
  3. embed-pdf does not work

Browsers Affected

  • Chrome
  • Firefox
  • Edge
  • Safari 11
  • Safari 10
  • IE 11

EDIT: I got search to work just by re-cloning the repo, but embed-pdf still seems to be missing something. The slider keeps loading, even when the number of pages is correctly estimated

@MarionMoseby MarionMoseby changed the title Can't get search and embed-pdf to work Can't get embed-pdf to work Dec 6, 2023
@kodiakhq kodiakhq bot closed this as completed in #844 Dec 8, 2023
@MarionMoseby
Copy link
Contributor Author

It works now - thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant