Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New french translation about Note feature on the navbar #872

Closed
2 tasks done
niltied opened this issue Jan 27, 2024 · 2 comments · Fixed by #875
Closed
2 tasks done

New french translation about Note feature on the navbar #872

niltied opened this issue Jan 27, 2024 · 2 comments · Fixed by #875

Comments

@niltied
Copy link
Contributor

niltied commented Jan 27, 2024

Hi,

Just a little request, easy to revolve.

Definition of Ready

When Toha was configured in French AND Notes feature is enabled in config.yaml (or alternatively hugo.yaml), Notes title in the navbar, is translated as Remarques in French. It's a really strange title in the navigation bar for french people. It's better to keep Notes title in French too, just like English.

Definition of Done

  • Change the french Translation about Remarques word for the Notes feature in the navbar.
  • It mustn't also forget the same translation on Root menu in the sidebar on the Notes frontend.

Is it possible to change this to the next minor release of Toha @hossainemruz ?

Thank,

@BernatBC
Copy link
Contributor

You can modify the file i18n/fr.toml, changing the following lines:

[notes]
other = "Remarques"

to:

[notes]
other = "Notes"

@niltied
Copy link
Contributor Author

niltied commented Jan 28, 2024

Hi @BernatBC and @hossainemruz,

So, it's done. See my MR #875. Thank U @BernatBC for your guide. Indeed, it was easy to solve even for me.

@niltied niltied closed this as completed Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants