gef-extras stuff for #576 and #577 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Nov 15, 2020
|
|
||
| def gen_json(function_dict,_params,outfile_name): | ||
| _dict = {} | ||
| for _key,_value in function_dict.items(): |
There was a problem hiding this comment.
Fix spaces after commas
| if os.path.isfile(outfile_name): | ||
| print("file {} exists, overwrite? [Y/n]".format(outfile_name)) | ||
| overwrite = input() | ||
| if 'n' in overwrite.lower(): |
There was a problem hiding this comment.
It's 'safer' to flip this: Assume no unless they put in a y, otherwise them mashing the keyboard would overwrite the file.
|
|
||
| return | ||
|
|
||
| file_name = 'libc.txt.gz' |
There was a problem hiding this comment.
Let's put this all in a 'main' function, so that we can import this file to test the other functions, if we end up using it a lot.
| function_name = get_function_name(line) | ||
| function_args = get_function_args(line) | ||
|
|
||
| #print("fname {} || fargs {}".format(function_name,function_args)) |
|
|
||
| #print("fname {} || fargs {}".format(function_name,function_args)) | ||
|
|
||
| # there is two dupes as of now, i'm ignoring the issue by having the last to rule by initializing dict key again |
There was a problem hiding this comment.
Suggested change
| # there is two dupes as of now, i'm ignoring the issue by having the last to rule by initializing dict key again | |
| # there are two dupes as of now, get around the issue by using the last one found |
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Grazfather
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gef-extras stuff for hugsy/gef#576 and hugsy/gef#577