-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gef-extras stuff for #576 and #577 #26
Conversation
|
||
def gen_json(function_dict,_params,outfile_name): | ||
_dict = {} | ||
for _key,_value in function_dict.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix spaces after commas
if os.path.isfile(outfile_name): | ||
print("file {} exists, overwrite? [Y/n]".format(outfile_name)) | ||
overwrite = input() | ||
if 'n' in overwrite.lower(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 'safer' to flip this: Assume no unless they put in a y
, otherwise them mashing the keyboard would overwrite the file.
|
||
return | ||
|
||
file_name = 'libc.txt.gz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this all in a 'main' function, so that we can import this file to test the other functions, if we end up using it a lot.
function_name = get_function_name(line) | ||
function_args = get_function_args(line) | ||
|
||
#print("fname {} || fargs {}".format(function_name,function_args)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
|
||
#print("fname {} || fargs {}".format(function_name,function_args)) | ||
|
||
# there is two dupes as of now, i'm ignoring the issue by having the last to rule by initializing dict key again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# there is two dupes as of now, i'm ignoring the issue by having the last to rule by initializing dict key again | |
# there are two dupes as of now, get around the issue by using the last one found |
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
gef-extras stuff for hugsy/gef#576 and hugsy/gef#577