Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after (successful) penalty shot #1401

Closed
schmidma opened this issue Jul 20, 2024 · 2 comments
Closed

Crash after (successful) penalty shot #1401

schmidma opened this issue Jul 20, 2024 · 2 comments
Assignees
Labels
is:Bug This is a bug and should be prioritised.

Comments

@schmidma
Copy link
Member

schmidma commented Jul 20, 2024

We crash after a penalty shot:

2024-07-20-HULKs-vs-SPQR/first-half/10.1.24.39/2024-07-20_14:23:06/hulk.err

and

2024-07-20-HULKs-vs-SPQR/first-half/10.1.24.39/2024-07-20_14:39:16/hulk.err
@schmidma schmidma added the is:Bug This is a bug and should be prioritised. label Jul 20, 2024
@schluis schluis self-assigned this Jul 20, 2024
@knoellle
Copy link
Contributor

knoellle commented Jul 20, 2024

Likely culprit in role assigment:

        if let Some(SubState::PenaltyKick) = game_controller_state.sub_state {
            return (current_role, false, None);
        }

In penalty kick we are always enforcing the previous role which might

  • leave us without a striker if there wasn't one at the time this state is entered
  • cause a robot to be striker without a ball or team ball, which is fatal.

@knoellle
Copy link
Contributor

Fixed by #1402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:Bug This is a bug and should be prioritised.
Projects
Status: Done
Development

No branches or pull requests

3 participants