Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release date #34

Closed
olexandr-konovalov opened this issue Aug 22, 2018 · 4 comments
Closed

Fix release date #34

olexandr-konovalov opened this issue Aug 22, 2018 · 4 comments

Comments

@olexandr-konovalov
Copy link
Contributor

The date in the latest release breaks validation:

* TransGrp - new version 2.0.3 discovered!!!
  ============================================
  Getting new archives from 
  http://www.math.colostate.edu/~hulpke/transgrp/transgrp2.0.3[ ".tar.gz" ]
  unpacking transgrp2.0.3.tar.gz
#E  component `Date' must be bound to a string of the form `dd/mm/yyyy'
  ERROR (TransGrp): validation of the info file not successful! SKIPPING!!!

Could you please fix it accordingly to the comments that someone placed above it in PackageInfo.g file:

transgrp/PackageInfo.g

Lines 13 to 16 in 55a90d6

## Release date of the current version in dd/mm/yyyy format.
## Note that the clever package tools cannot deal with single digits, but
## will whine.
Date := "8/31/2018",

Note that using ReleaseTools would report this immediately and allow to avoid this situation. If you're not using ReleaseTools, you still can call ValidatePackageInfo locally before publishing the release.

@fingolfin
Copy link
Collaborator

Note that there are two problems: 8 should be 08, and the order of day and month are switched.

@olexandr-konovalov
Copy link
Contributor Author

Also, the date need not to be in the future.

@hulpke
Copy link
Owner

hulpke commented Aug 31, 2018

Fixed. (Is there a reason not to allow single digit numbers?)

@hulpke hulpke closed this as completed Aug 31, 2018
@olexandr-konovalov
Copy link
Contributor Author

Thanks. It is a consistent style that is in use for more than 10 years - I can track lines in ValidatePackageInfo.g which require this format being unchanged since

changeset:   15110:291ee24f4089
user:        Thomas Breuer 
date:        Wed Nov 26 16:16:00 2008 +0000
summary:     split `lib/package.g' into `lib/package.gd' and `lib/package.gi',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants