Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gaussholder dependency to 1.1.5 #233

Open
3 tasks
goldenapples opened this issue Apr 28, 2022 · 3 comments
Open
3 tasks

Update Gaussholder dependency to 1.1.5 #233

goldenapples opened this issue Apr 28, 2022 · 3 comments
Labels
bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now

Comments

@goldenapples
Copy link

goldenapples commented Apr 28, 2022

I noticed that Gaussholder is pinned to a release a couple point releases behind current:

"humanmade/gaussholder": "1.1.3",

Could this be updated to the latest point release?


Edit: approved by @roborourke

Acceptance crtiteria:

  • Update Gaussholder to 1.1.5
  • Update Gaussholder version constraint to allow patch updates e.g. ~1.1.5
  • Backport to all LTS versions
@goldenapples goldenapples added the bug Existing functionality isn't behaving as expected label Apr 28, 2022
@roborourke roborourke added the to refine Issues needing refinement. label May 11, 2022
@roborourke
Copy link
Contributor

I think so, not sure why dependabot isn't doing that 🤔

There might have been a reason if the patch release wasn't strictly a patch release but it's likely just an oversight.

@roborourke roborourke added should have Should be done, medium priority for now and removed to refine Issues needing refinement. labels May 12, 2022
@robindevitt
Copy link
Contributor

@roborourke I was looking into this issue:

Update Gaussholder to 1.1.5

This is relevant to https://github.com/humanmade/Gaussholder correct? Where it's current version is 1.1.3 based on the tags, looking a the code changes there were some cases that it was bumped to 1.1.5 and some cases it's still 1.1.4. Just to confirm this acceptance criteria is to being that up to date first?

@roborourke
Copy link
Contributor

@robindevitt it is referring to that repo yeah, I think it's safe to update the version constraint as noted in the acceptance criteria, which versions of Altis are pinned to which tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now
Projects
None yet
Development

No branches or pull requests

3 participants