Fix integration with tag manager #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tag manager was removed with v17 in the analytics module this consent API integration has been broken because the inline script never got added. It's fine to just enqueue all the time now, if there's no tag manager loaded on the page then it just won't do anything.
|
@rmccue @mikelittle Happy to update this PR to remove the integration altogether, but will need to update the upgrade guide and communicate it to everyone who has upgraded to v17 so far. |
mikelittle
approved these changes
Jan 30, 2024
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tag manager was removed with v17 in the analytics module this consent API integration has been broken because the inline script never got added.
It's fine to just enqueue all the time now, if there's no tag manager loaded on the page then it just won't do anything.