Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow use function and use const #188

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mikeselander
Copy link
Contributor

This addition disallows developers from using functions, while keeping the ability to use namespaces and constants.

Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!

@mikeselander mikeselander linked an issue Apr 6, 2020 that may be closed by this pull request
@jrfnl
Copy link

jrfnl commented Apr 7, 2020

Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!

Well, didn't build it just for you, but glad you like it. ;-)

@mikeselander mikeselander changed the title Disallow use function Disallow use function and use const May 19, 2020
Comment on lines +6 to +7
"minimum-stability": "dev",
"prefer-stable": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes intentional? Neither of them will have any effect if the project isn't the root project.

Copy link
Contributor Author

@mikeselander mikeselander May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were, yes. phpcsextra is only released as alpha and it wouldn't install without adding these in: https://github.com/PHPCSStandards/PHPCSExtra/releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we'll have to hold on releasing this then until phpcsextra is released, as the minimum-stability won't flow through, and would make the coding standards uninstallable as a dependency.

@roborourke
Copy link
Contributor

Requested a stable release: PHPCSStandards/PHPCSExtra#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider disallowing use of use function...
5 participants