Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT][Exchange/Recording Oracles] Add encryption support #2272

Merged
merged 13 commits into from
Aug 7, 2024

Conversation

Marishka17
Copy link
Collaborator

@Marishka17 Marishka17 commented Jul 11, 2024

Description

This PR enables decryption of downloaded escrow manifests that Job Launcher encryptes

Summary of changes

  • Python SDK:
    • Added EncryptionUtils.is_encrypted method to check whether data is encrypted or not
  • CVAT Oracles:
    • Set Oracle PGP_PUBLIC_KEY_URL to KVStore when starting service if there is no such key URL in KVStore or the key/URL has changed
    • Check whether escrow manifest is encrypted and decrypt them using PGP_PRIVATE_KEY/PGP_PASSPHRASE if necessary
    • PR adds 3 new environment variables (per oracle) to handle encryption: PGP_PRIVATE_KEY, PGP_PASSPHRASE, PGP_PUBLIC_KEY_URL

How test the changes

Added unit tests for Exchange/Recording Oracles and for python SDK

Related issues

Keywords for linking issues

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 11:55am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 11:55am

zhiltsov-max
zhiltsov-max previously approved these changes Jul 12, 2024
@Dzeranov
Copy link
Contributor

Lgtm.
Once we prepare a staging environment for these changes (public key generation, etc.) will approve and merge.

@Dzeranov Dzeranov merged commit ef5c662 into develop Aug 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVAT CVAT oracles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants