-
Notifications
You must be signed in to change notification settings - Fork 73
Improve Travis matrix #207
Changes from 6 commits
adcd387
fbc92b7
3d3e76a
9d914a9
7377007
5202f15
e755a06
e1e9a85
b64f9bd
ae2bbe8
c18a8a9
495f5b7
8b605cd
d332be9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,37 @@ | ||
language: php | ||
sudo: false | ||
|
||
php: | ||
- 7.0 | ||
- 5.6 | ||
- 5.5 | ||
- 5.4 | ||
- hhvm | ||
- hhvm-nightly | ||
|
||
matrix: | ||
include: | ||
- php: 5.4 | ||
env: COMPOSER_FLAGS='--prefer-lowest' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be simpler to just add an env block later? e.g.
Keeps the list of flags and versions distinct? |
||
- php: 5.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can skip the flags here as it's the default behaviour |
||
- php: 5.5 | ||
env: COMPOSER_FLAGS='--prefer-lowest' | ||
- php: 5.5 | ||
- php: 5.6 | ||
env: COMPOSER_FLAGS='--prefer-lowest' | ||
- php: 5.6 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. versions should be strings |
||
- php: 7.0 | ||
env: COMPOSER_FLAGS='--prefer-lowest' | ||
- php: 7.0 | ||
- php: 7.1 | ||
env: COMPOSER_FLAGS='--prefer-lowest' | ||
- php: 7.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we're missing a |
||
env: PHPUNIT_FLAGS='--coverage-text' | ||
- php: hhvm | ||
env: COMPOSER_FLAGS='--prefer-lowest' | ||
- php: hhvm | ||
fast_finish: true | ||
allow_failures: | ||
- php: 7.0 | ||
- php: hhvm | ||
- php: hhvm-nightly | ||
|
||
cache: | ||
directories: | ||
- $HOME/.composer/cache | ||
|
||
before_install: | ||
- travis_retry composer self-update | ||
|
||
before_script: | ||
- travis_retry composer install --no-interaction | ||
- composer update --no-interaction --prefer-dist $COMPOSER_FLAGS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make a sense |
||
|
||
script: | ||
- vendor/bin/phpunit --coverage-text | ||
- vendor/bin/behat | ||
- vendor/bin/phpunit $PHPUNIT_FLAGS | ||
- vendor/bin/behat -vv | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should put it in verbose mode, however we could do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both non verbose + progress + fail fast are for fast builds detecting as early as possible if things pass or not. Figuring out why should be done locally, and for issues where it's hard to reproduce locally the user can always change the verbosity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #226, we can remove the EOL php versions 5.3 to 5.5.