This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Handle mocking objects for both PHPUnit 4 and 5 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
reviewed
Apr 18, 2017
composer.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| }, | |||
| "require": { | |||
| "php": ">=5.4.0", | |||
| "phpunit/phpunit": "^4.5|^5.0", | |||
| "phpunit/phpunit": "^4.5|^5.0|<=6.0", | |||
There was a problem hiding this comment.
^4.5|^5.0 already conflicts with 6.0 (and you allowed for 6.0 by <= 🎉).
There was a problem hiding this comment.
not exactly as you wrote - https://getcomposer.org/doc/articles/versions.md#caret
ok, it should work as you wrote
|
|
||
| class XmlConfigurationTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| use PHPUnitHandleDeprecatedMethodsTrait; |
There was a problem hiding this comment.
Some comment to remove it after dropping support for PHPUnit 4 will be welcomed :)
pamil
approved these changes
Apr 18, 2017
|
@GrahamCampbell with dropping support for PHPUnit 4 we will drop support for PHP 5.4 and 5.5 |
I'm fine with that. I think PHP 5.6 is a good minimum version to use for the next 2 years or so. |
padraic
approved these changes
Apr 19, 2017
Merged
ghost
deleted the
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
Update README.md markdown fix Update README.md Add migration notice & update clone URL Update Travis CI and Scrutinizer badges in readme Apply fixes from StyleCI Run Travis builds for all branches Unify version displaying format Add a download counter to the readme (humbug#222) Make Behat tests up and running (humbug#224) Forces humbug to use the phpunit downloaded using Composer. Handle mocking objects for both PHPUnit 4 and 5 (humbug#226) Support for optionally configuring phpunit executable (humbug#155) Change PHAR compression from bz2 to gzip (humbug#205) Allow to be run with phpdbg (humbug#184) Remove white spaces Improve Travis matrix (humbug#207) Support adding env variables; by default use this to disable Symfony deprecation notices. Fixes @42
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new PHPUnit 6.0 does not support tap parameter, TAP format is not supported any more in PHPUnit 6 - https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#removed