Improve Travis matrix #207

snapshotpl · 2017-03-04T22:17:45Z

Improve deps testing,
add php 7.1,
php7.* must pass tests

theofidry

Nice PR, I left a few comments but quite like the PR :)

theofidry · 2017-03-05T00:06:07Z

.travis.yml

 matrix:
+  include:
+    - php: 5.4
+      env: DEPS=lowest


COMPOSER_FLAGS='--prefer-lowest'

theofidry · 2017-03-05T00:06:27Z

.travis.yml

+  include:
+    - php: 5.4
+      env: DEPS=lowest
+    - php: 5.4


I think you can skip the flags here as it's the default behaviour

theofidry · 2017-03-05T00:12:01Z

.travis.yml

+    - php: 5.5
+      env: DEPS=lowest
+    - php: 5.5
+      env: DEPS=latest


doubling the number of tests looks a bit too much to me. Having a test for the two extrema plus one for each version is enough I think

theofidry · 2017-03-05T00:13:11Z

.travis.yml

+      env: DEPS=latest
+    - php: 7.1
+      env: DEPS=lowest
+    - php: 7.1


we're missing a nightly build that should be allowed to fail

theofidry · 2017-03-05T00:14:14Z

.travis.yml

@@ -28,8 +50,9 @@ before_install:
  - travis_retry composer self-update


this is no longer necessary, although it's not related to this PR I think you can take the opportunity to remove it

theofidry · 2017-03-05T00:16:04Z

.travis.yml

@@ -28,8 +50,9 @@ before_install:
  - travis_retry composer self-update

 before_script:
-  - travis_retry composer install --no-interaction
+  - if [[ $DEPS == 'latest' ]]; then travis_retry composer update --no-interaction --prefer-source ; fi


With my first comment, this [the two added lines] can be simplified to composer update --no-interaction --prefer-source $COMPOSER_FLAGS

theofidry · 2017-03-05T00:17:15Z

.travis.yml


 script:
-  - vendor/bin/phpunit --coverage-text
+  - if [[ $TEST_COVERAGE == 'true' ]]; then vendor/bin/phpunit --coverage-text ; else vendor/bin/phpunit ; fi


if [ -n "$TEST_COVERAGE" ]; then?

Single brackets are also enough AFAIK

theofidry · 2017-03-05T00:17:54Z

.travis.yml

@@ -1,21 +1,43 @@
 language: php
 sudo: false


also no part of the goal of this PR, can be removed as well

ghost · 2017-04-10T08:40:50Z

.travis.yml

+      env: DEPS=lowest
+    - php: hhvm
+      env: DEPS=latest
+    - php: hhvm-nightly


HHVM nightly is no longer supported on TravisCI - travis-ci/travis-ci#3788, so it should be removed

ghost · 2017-04-14T10:27:51Z

Could you please adapt also those changes in our PR:

composer.json

"phpunit/phpunit": "^4.5|^5.0|<=6.0"

new PHPUnit 6.0 does not support tap parameter, TAP format is not supported any more in PHPUnit 6 - https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#removed

features/version.feature
replace Humbug version 1.0-dev with Humbug 1.0-dev current Humbug humbug.phar --version also doesn't print Humbug version (...)

snapshotpl · 2017-04-14T11:55:46Z

@piotr-zuralski I think this changes what you said should be part of other pull requrest.

ghost · 2017-04-14T11:59:27Z

@snapshotpl Those changes are already waiting in other PRs and without them builds will keep failing.
I suppose that filed build might also block merging of this PR

snapshotpl · 2017-04-14T13:46:59Z

Ok, so when they will be merged into develop/master I can rebase it here. There's no sense to duplicate work

pamil · 2017-04-14T17:10:06Z

.travis.yml

  fast_finish: true
  allow_failures:
-    - php: 7.0
    - php: hhvm
    - php: hhvm-nightly


There's no hhvm-nightly build now :)

pamil · 2017-04-14T17:12:02Z

.travis.yml

 before_script:
-  - travis_retry composer install --no-interaction
+  - composer update --no-interaction --prefer-source $COMPOSER_FLAGS


Is there some reason to put --prefer-source here? Installing source packages takes more time than dist ones.

pamil · 2017-04-14T17:13:23Z

.travis.yml


 script:
-  - vendor/bin/phpunit --coverage-text
+  - if [[ $TEST_COVERAGE == 'true' ]]; then vendor/bin/phpunit --coverage-text ; else vendor/bin/phpunit ; fi


What do you think about introducing $PHPUNIT_FLAGS? This way we can remove if from this statement.

pamil · 2017-04-14T17:14:17Z

Closing and reopening to force build on humbug/humbug :)

snapshotpl · 2017-04-14T17:51:17Z

Give 10 minutes to fix that

padraic

Two suggestions from me.

padraic · 2017-04-19T14:33:50Z

.travis.yml


 matrix:
+  include:
+    - php: 5.4
+      env: COMPOSER_FLAGS='--prefer-lowest'


Would it be simpler to just add an env block later? e.g.

env: matrix: - COMPOSER_FLAGS="--prefer-lowest" - COMPOSER_FLAGS=""

Keeps the list of flags and versions distinct?

padraic · 2017-04-19T14:36:12Z

.travis.yml


 matrix:
+  include:
+    - php: 5.4


Per #226, we can remove the EOL php versions 5.3 to 5.5.

theofidry

Last round :)

theofidry · 2017-04-20T17:52:22Z

.travis.yml

-  - vendor/bin/phpunit --coverage-text
-  - vendor/bin/behat
+  - vendor/bin/phpunit $PHPUNIT_FLAGS
+  - vendor/bin/behat -vv


I don't think we should put it in verbose mode, however we could do -f progress --stop-on-failure and add a --stop-on-failure for PHPUnit as well

-f progress - good idea. Verbose can be helpful for debugging without running on local machine.
--stop-on-failure? I think is better to get all issues in one build.

both non verbose + progress + fail fast are for fast builds detecting as early as possible if things pass or not. Figuring out why should be done locally, and for issues where it's hard to reproduce locally the user can always change the verbosity.

theofidry · 2017-04-20T17:52:36Z

.travis.yml

 before_script:
-  - travis_retry composer install --no-interaction
+  - composer update --no-interaction --prefer-dist $COMPOSER_FLAGS


I would add --no-suggest as well

Make a sense

theofidry · 2017-04-20T17:52:59Z

.travis.yml

 matrix:
+  include:
+    - php: 5.6


versions should be strings

theofidry · 2017-04-20T17:53:19Z

.travis.yml

    - php: hhvm

+env:
+  matrix:
+    - COMPOSER_FLAGS="--prefer-lowest"


to stay consistent let's keep it at single quotes :)

snapshotpl · 2017-04-20T18:38:08Z

This PR shows that humbug's tests don't work well with phpunit in version 5.0. Should we remove phpunit >5.0 features or change minimum version of phpunit?

padraic · 2017-04-20T18:56:21Z

Yes, there's been a lot of drift over time so it's messy getting the CI just right. The basic migration plan is to do just enough to make Humbug pass in its present state. Once "just enough" is accomplished, we're going straight to 2.0 on Humbug, and we can support PHPUnit 5-6 any way we want.

That may require paring back on PHPUnit features for a brief period (e.g. using exception annotations, not the methods, and so on, which are the same across 4,5&6) - also we have hard upper limits (Humbug 1 needs TAP support, for e.g.).

snapshotpl · 2017-04-20T22:28:38Z

PHPUnit compatibility improved. However php 7 still fall. But it's problem for another PR, because this scenario alread falls in master https://travis-ci.org/humbug/humbug/jobs/223862748 . disable allow_failures change game rules ;)

pamil

👍, commits need to be squashed on merge though :)

padraic · 2017-04-21T10:33:41Z

Thanks @snapshotpl!

theofidry · 2017-04-21T10:53:52Z

I'm really missing the thanks in the PRs lately... soz about that

@42

Update README.md markdown fix Update README.md Add migration notice & update clone URL Update Travis CI and Scrutinizer badges in readme Apply fixes from StyleCI Run Travis builds for all branches Unify version displaying format Add a download counter to the readme (humbug#222) Make Behat tests up and running (humbug#224) Forces humbug to use the phpunit downloaded using Composer. Handle mocking objects for both PHPUnit 4 and 5 (humbug#226) Support for optionally configuring phpunit executable (humbug#155) Change PHAR compression from bz2 to gzip (humbug#205) Allow to be run with phpdbg (humbug#184) Remove white spaces Improve Travis matrix (humbug#207) Support adding env variables; by default use this to disable Symfony deprecation notices. Fixes @42

Improve deps testing, add php 7.1, php7 must pass tests

adcd387

snapshotpl changed the title ~~Improve deps testing, add php 7.1, php7 must pass tests~~ Improve tests Mar 4, 2017

snapshotpl added 2 commits March 4, 2017 23:25

Disable xdebug and check coverage once to improve test time

fbc92b7

xdebug must be enabled

3d3e76a

theofidry suggested changes Mar 5, 2017

View reviewed changes

ghost reviewed Apr 10, 2017

View reviewed changes

Simplify travis

9d914a9

pamil reviewed Apr 14, 2017

View reviewed changes

pamil closed this Apr 14, 2017

pamil reopened this Apr 14, 2017

pamil mentioned this pull request Apr 14, 2017

Make Humbug tests up and running #219

Closed

Improve composer

7377007

snapshotpl mentioned this pull request Apr 14, 2017

Run Travis builds for all branches #220

Merged

Merge branch 'master' into improve-testing

5202f15

padraic suggested changes Apr 19, 2017

View reviewed changes

theofidry changed the title ~~Improve tests~~ Improve Travis matrix Apr 19, 2017

theofidry added this to the 1.0.0 milestone Apr 19, 2017

snapshotpl added 2 commits April 20, 2017 19:43

Merge branch 'master' into improve-testing

e755a06

Use matrix for env

e1e9a85

theofidry suggested changes Apr 20, 2017

View reviewed changes

snapshotpl added 4 commits April 20, 2017 20:01

Fix travis

b64f9bd

Fix travis

ae2bbe8

Fix composer

c18a8a9

Exclude php 7.1 without coverage

495f5b7

Small improvements

8b605cd

padraic approved these changes Apr 20, 2017

View reviewed changes

Add phpunit 5.0 compatibility

d332be9

pamil approved these changes Apr 21, 2017

View reviewed changes

theofidry merged commit 34a1348 into humbug:master Apr 21, 2017

tabbabi pushed a commit to tabbabi/humbug that referenced this pull request Aug 4, 2017

Improve Travis matrix (humbug#207)

2e3d328

tabbabi pushed a commit to tabbabi/humbug that referenced this pull request Aug 4, 2017

Improve Travis matrix (humbug#207)

f173503

		@@ -28,8 +50,9 @@ before_install:
		- travis_retry composer self-update

Improve Travis matrix #207

Improve Travis matrix #207

Conversation

snapshotpl commented Mar 4, 2017 • edited Loading

theofidry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Apr 14, 2017 • edited by ghost Loading

snapshotpl commented Apr 14, 2017

ghost commented Apr 14, 2017 • edited by ghost Loading

snapshotpl commented Apr 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pamil commented Apr 14, 2017

snapshotpl commented Apr 14, 2017

padraic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theofidry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snapshotpl commented Apr 20, 2017

padraic commented Apr 20, 2017

snapshotpl commented Apr 20, 2017

pamil left a comment

Choose a reason for hiding this comment

padraic commented Apr 21, 2017

theofidry commented Apr 21, 2017

snapshotpl commented Mar 4, 2017 •

edited

Loading

ghost commented Apr 14, 2017 •

edited by ghost

Loading

ghost commented Apr 14, 2017 •

edited by ghost

Loading