Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming events widget not shown if no upcoming events #455

Open
dantefromhell opened this issue Feb 13, 2024 · 4 comments
Open

Upcoming events widget not shown if no upcoming events #455

dantefromhell opened this issue Feb 13, 2024 · 4 comments

Comments

@dantefromhell
Copy link
Contributor

dantefromhell commented Feb 13, 2024

This behaviour had me confused for quite a bit, maybe it is intentional.

When the Upcoming events widget is enabled but the calendar has no entries, the whole widget won't be displayed.
When doing space configuration this can be very confusing, as Space Owners might think the function is disabled.

IMO a better solution would be to display the Upcoming events widget with a small No events yet string.

I'm happy to try my hand on a PR, some guidance might be required though.

@dantefromhell
Copy link
Contributor Author

This turned out to be quicker than expected.

I've created a draft PR because the approach has not been discussed/ approved by upstream. Please advise if this solution is in line with HumHubs standards.

@luke-
Copy link
Contributor

luke- commented Feb 14, 2024

Thanks for the Draft PR.

Hmm, a configuration option could be useful here. Currently the Space Admin can't control whether the widget is displayed, or not?

@dantefromhell
Copy link
Contributor Author

Currently the Space Admin can't control whether the widget is displayed, or not?

That's my understanding, yes.
I do agree on the configuration option to be a good addition too.

Would that be part of this issue/ PR or a new issue/PR?

@luke-
Copy link
Contributor

luke- commented Feb 14, 2024

You are welcome to integrate it into your current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants