-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming events widget not shown if no upcoming events #455
Comments
This turned out to be quicker than expected. I've created a draft PR because the approach has not been discussed/ approved by upstream. Please advise if this solution is in line with HumHubs standards. |
Thanks for the Draft PR. Hmm, a configuration option could be useful here. Currently the Space Admin can't control whether the widget is displayed, or not? |
That's my understanding, yes. Would that be part of this issue/ PR or a new issue/PR? |
You are welcome to integrate it into your current PR. |
This behaviour had me confused for quite a bit, maybe it is intentional.
When the
Upcoming events
widget is enabled but the calendar has no entries, the whole widget won't be displayed.When doing space configuration this can be very confusing, as Space Owners might think the function is disabled.
IMO a better solution would be to display the
Upcoming events
widget with a smallNo events yet
string.I'm happy to try my hand on a PR, some guidance might be required though.
The text was updated successfully, but these errors were encountered: