Facebook Fixes #732
Merged
Facebook Fixes #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't save and then confirm Facebook users, `confirm!` already saves for us under the hood. This will fix Facebook users being sent a confirmation email which doesn't work.
|
Out of curiosity why does the |
|
Doesn't really break it, it just causes confusion IMO. #save causes the confirmation email to be sent, then right after #confirm! On Sun, Jun 12, 2016 at 5:28 AM Peter Lejeck notifications@github.com
|
|
Ah, that makes sense. LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some fixes for Facebook based accounts that have been brought to my attention.