Prevent unnecessary Copy-on-Write behaviour in HTTPFields #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
commented
May 19, 2024
| set { self.head.headerFields = newValue } | ||
| } | ||
| public var status: HTTPResponse.Status | ||
| public var headers: HTTPFields |
There was a problem hiding this comment.
First of all, modifying response.headers was leading to a CoW. This is because headers was a getter/setter, thus copied the value from head. I've reversed this relationship
Joannis
commented
May 19, 2024
| self.body = body | ||
| if let contentLength = body.contentLength, headers[.contentLength] == nil { | ||
| self.head.headerFields[.contentLength] = String(describing: contentLength) | ||
| if let contentLength = body.contentLength, self.headers[.contentLength] == nil { |
There was a problem hiding this comment.
self. was missing, leading to the original headers still being references. This lead to there being two active copies, which would cause a CoW
adam-fowler
added a commit
that referenced
this pull request
May 20, 2024
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
adam-fowler
added a commit
that referenced
this pull request
May 20, 2024
* Don't create ByteBuffer before we know its length * Minor JSON change for performance test * Add content-length to response generator body init * Use HTTPFields.contains Doesn't construct http field contents * Use NIO helpers * Combined with PR #458 Co-authored-by: Joannis Orlandos <joannis@orlandos.nl> --------- Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
|
These changes were merged with #454 so this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.