Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve #20 #26

Closed
wants to merge 13 commits into from
Closed

resolve #20 #26

wants to merge 13 commits into from

Conversation

shivanigupta19
Copy link

issue solved by shivani #20
Please close the issue.

jitinder and others added 13 commits June 20, 2020 20:12
@jitinder
Add support for type weaknesses
3ff9540
@jitinder
Changes made to Type Weaknesses
640109e
@hungps
Merge pull request hungps#14 from jitinder/updates
e9bcc4c 
Add support for type weaknesses
@jitinder
Add data for Abilities till gen 7
ff5fe69
@jitinder
Add abilities JSON
a39792e
@hungps
Merge pull request hungps#16 from jitinder/updates
1844ab2 
Add data for Abilities till gen 7
@hungps
resolve hungps#12
de7d5f3
@hungps
Merge pull request hungps#21 from scitbiz/update_homescreen_spacing
67549dd 
Update home screen spacing
@hungps
ignore click event of pokeball behide appbar in pokemon info page
d1b0d63
@hungps
Merge pull request hungps#22 from scitbiz/ignore_appbar_pokeball
d0b495b 
Ignore click event of pokeball behide appbar in pokemon info page
@jitinder
fix FAB opening and closing
cde2f5f
@hungps
Merge pull request hungps#23 from jitinder/master
2aea624 
Fix FAB opening and closing
@shivanigupta19
issue solved by shivani
8075401
@hungps hungps mentioned this pull request Aug 14, 2020
Closed
@hungps
Copy link
Owner

hungps commented Oct 2, 2020

@shivanigupta19 Hi, thanks for creating this pull request.
Due to the lack of a message of @i-schuetz, I will consider it will fix this issue because it only has a small effect on the project.
Please rename your commit and pull title to something meaningful (like resolve #20). Also, remove all unnecessary changes and only focusing on the change which fixed the issue.

Thanks again!

@shivanigupta19 shivanigupta19 changed the title issue solved by shivani #20 resolve #20 Oct 3, 2020
@shivanigupta19
Copy link
Author

@scitbiz sorry please clear your sentence again

@hungps
Copy link
Owner

hungps commented Oct 5, 2020

@shivanigupta19, please also change your commit message to resolve #20 and uncommit the pubspec.lock file. Thanks!

@hungps
Copy link
Owner

hungps commented Nov 1, 2020

I'll close this issue here because there is no action coming up and the master branch has changed. If you still want to fix this issue, please open a new pull request based on the new master branch. Thank you!

@hungps hungps closed this Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shivanigupta19 @hungps @jitinder