Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove role=button in Button #6

Closed
Klustre opened this issue Aug 7, 2023 · 1 comment · Fixed by #10
Closed

Remove role=button in Button #6

Klustre opened this issue Aug 7, 2023 · 1 comment · Fixed by #10

Comments

@Klustre
Copy link

Klustre commented Aug 7, 2023

Thanks a lot for your efforts on this Hunter! Svelte desperately needs a proper UI library and I'm looking forward using it in my projects.

I noticed role=button is used in the Button component which incorrectly tells screen readers that the link is a button, but it's merely displayed as a button. It doesn't have the same functionality.

See mdn and this picocss issue.

When omitting the href param it actually is a button which should make role=button unnecessary.

@huntabyte
Copy link
Owner

Thanks for this! This specific repo is still very young and experimental!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants