Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply queue is created even if opts.reply is set to false #53

Closed
danwkennedy opened this issue Jul 5, 2016 · 2 comments
Closed

Reply queue is created even if opts.reply is set to false #53

danwkennedy opened this issue Jul 5, 2016 · 2 comments

Comments

@danwkennedy
Copy link

In lib/exchange.js, the sendMessage() method checks for opts.reply to interact with a replyQueue. However, when the exchange is created, the replyQueue is always created regardless of the value of opts.reply. This creates a bunch of un-named queues that we're not actually using (especially since a lot of our connections to an exchange are for listening to the queue instead of writing to it).

Could you check the opts and create the queue if necessary?

If that's an acceptable solution, I'd be willing to submit a PR for that check.

@matmar10
Copy link
Collaborator

Hi @danwkennedy - this seems like a completely reasonable solution. Could you create a PR for this?

@matmar10
Copy link
Collaborator

matmar10 commented Jul 8, 2018

This should be fixed

@matmar10 matmar10 closed this as completed Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants