Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-server condition overwrites main dist files #541

Closed
amannn opened this issue Jun 11, 2024 · 2 comments · Fixed by #543
Closed

react-server condition overwrites main dist files #541

amannn opened this issue Jun 11, 2024 · 2 comments · Fixed by #543
Labels
area:bug Something isn't working

Comments

@amannn
Copy link

amannn commented Jun 11, 2024

Hey, me again with a rather special bug report regarding export conditions! :)

I noticed that under a certain condition, the react-server export condition overwrites the the main dist files.

Here's a reproduction: amannn/bunchee-test@81357ab

The key is the renaming src/rsc/test.tssrc/rsc/index.ts. The build output should stay the same in this example, but as you see in the commit, the main dist files are overwritten.

It seems like the usage of index.ts somehow breaks the output?

@huozhi
Copy link
Owner

huozhi commented Jun 12, 2024

Thanks for report! Fixed in 5.2.0

@amannn
Copy link
Author

amannn commented Jun 13, 2024

Seems to work, thanks a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants