Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

individual run example needs updating #188

Closed
mwalzer opened this issue Mar 24, 2022 · 2 comments · Fixed by #189
Closed

individual run example needs updating #188

mwalzer opened this issue Mar 24, 2022 · 2 comments · Fixed by #189
Assignees
@mwalzer
Milestone
v1.0RC1

Comments

@mwalzer
Copy link
Collaborator

mwalzer commented Mar 24, 2022 •
edited
Loading

Uses wrong SHA term accession, name and value are correct, though.
@mwalzer mwalzer self-assigned this Mar 24, 2022
@mwalzer mwalzer changed the title individual run example uses wrong SHA term accession individual run example needs updating Mar 24, 2022
@mwalzer
Copy link
Collaborator Author

mwalzer commented Mar 24, 2022

Uses some QC CV terms:

QC:4000135 ! Number of chromatograms
QC:4000138 ! MZ acquisition range
QC:4000139 ! RT acquisition range

@mwalzer
Copy link
Collaborator Author

mwalzer commented Mar 24, 2022

will be replaced by MS:4000069-71 after HUPO-PSI/psi-ms-CV#112 is merged.

@mwalzer mwalzer mentioned this issue Mar 24, 2022
Merged
@mwalzer mwalzer added this to the v1.0RC1 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwalzer mwalzer

Labels
None yet
Projects
None yet
Milestone
v1.0RC1
Development

Successfully merging a pull request may close this issue.

fixing individual-run example CV use HUPO-PSI/mzQC
1 participant
@mwalzer