Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version and structure of repository #46

Closed
julianu opened this issue Sep 27, 2018 · 7 comments
Closed

New version and structure of repository #46

julianu opened this issue Sep 27, 2018 · 7 comments

Comments

@julianu
Copy link
Contributor

julianu commented Sep 27, 2018

In #44 I created a pull request for the version 0.1.0 for our CV.
Besides the starting from scratch of all terms, the CV imports the 0.0.8-legacy for backward compatibility. We should highlight somewhere (at least on the 1.0.0 release), that all terms below QC:4...... are deprecated. and should no longer be used. This could also easily be reflected in the legacy-cv later on.

As we also should have a stable link-position for the current versions of the CV, the file "qcML-development/cv/qc-cv.obo" was created, which should in the future always represent the newest active version. Besides it also resides the legacy version.

I think this also reflects your ideas @mwalzer, right?

Please comment or merge the PR.

@mwalzer
Copy link
Collaborator

mwalzer commented Oct 1, 2018

👍
I just created a label for v1.0
and a management board

@mwalzer mwalzer closed this as completed in 57f790d Oct 1, 2018
@poshul
Copy link
Contributor

poshul commented Sep 9, 2021

Playing necromancer here for a bit, finding what happened to the old CV's was challenging with current documentation. I'd suggest including a note somewhere in either the readme or the spec-doc as bread-crumbs for anyone getting up to speed.

@bittremieux
Copy link
Collaborator

Which version did you need specifically, and what is different about it?

Normally CV updates will only consist of additions, so the latest version should have all the terms of older versions as well. Why would you need an older version of the CV?

@poshul
Copy link
Contributor

poshul commented Sep 10, 2021 via email

@bittremieux
Copy link
Collaborator

I think loading the OBO from the old branch is going to be the best solution.

Moving from qcML to mzQC was a non-backwards compatible change, and merging the QC CV with the MS now, as required before finalization of mzQC v1.0 (#141), will definitely not be fully backwards compatible either.
This is not a major issue imo, because there are very few legacy systems that support qcML. Probably OpenMS is the only such system.

Are there blocking issues that require maintaining qcML support in OpenMS, rather than switching to mzQC? mzQC is easier to write and read and more powerful to store data, so why stick with qcML as only tool that supports it?

@mwalzer
Copy link
Collaborator

mwalzer commented Sep 15, 2021

Axel is working on that in OpenMS already, no? But if need be, we could create a dedicated legacy qcML branch, with the old stuffs, I suppose.

@poshul
Copy link
Contributor

poshul commented Sep 15, 2021

If we are the only software that's going to have to worry about backwards compatibility of reading the old files then I can just make a note in our code that uses the old CVs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants