Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide indication of invalid site #44

Closed
tcwaddell opened this issue Jun 13, 2018 · 4 comments
Closed

Provide indication of invalid site #44

tcwaddell opened this issue Jun 13, 2018 · 4 comments
Assignees

Comments

@tcwaddell
Copy link
Contributor

When an invalid site is specified with the '-s' argument, machinae does not give obvious feedback indicating that the site is invalid.

user@ubuntu:~$ machinae -s not_a_real_source A8EDE5B4E9AD5F52A3C28142FA26A4C2CAA2D9BD9E73AEAD41942D31986E4ABE
********************************************************************************
* Information for A8EDE5B4E9AD5F52A3C28142FA26A4C2CAA2D9BD9E73AEAD41942D31986E4ABE
* Observable type: hash.sha256 (Auto-detected: True)
********************************************************************************

user@ubuntu:~$
@billford billford self-assigned this Jun 14, 2018
@billford
Copy link
Contributor

Any preference for message that’s returned?

@tcwaddell
Copy link
Contributor Author

I did not have anything specific in mind.

@amg4110
Copy link

amg4110 commented Jun 14, 2018

I think it should say something like:

Error: Invalid source! Please run "machinae --list-sites", pick your poison, and try again.

Or something along those lines. :D

@billford
Copy link
Contributor

This entire thing made my eyes bleed. I will need to really really really dig in to make that work correctly and I have it somewhat worked out in a local branch. I added a message for now to check --list-sites if the results aren't what you expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants