All locale files bundled?

[theseushu]

I haven't tested yet, but seems
require('timeago.js/locales/' + this.props.locale));
will cause webpack to bundle all files under timeago.js/locales. (webpack has noway to know what value 'this.props.locale' could be, so it just includes all files in that folder)

Cannot find original docs, see this comment
webpack/webpack#38 (comment)

So code like this

  componentDidMount() {
    if (this.props.locale !== 'en' && this.props.locale !== 'zh_CN')
      timeago.register(this.props.locale, require('timeago.js/locales/' + this.props.locale));
      this.renderTimeAgo();
    },

is pretty much the same as require every thing statically.

The easiest solution shall be drop these lines, let user load locale files they need and pass to this component.

[theseushu]

okay, found docs
https://webpack.js.org/guides/dependency-management/#require-with-expression

[hustcc]

The easiest solution shall be drop these lines, let user load locale files they need and pass to this component.

Agree with this practice.

[hustcc]

I think remove the code below can solve it:

timeago.register(this.props.locale, require('timeago.js/locales/' + this.props.locale));

and developers register locales out of the component, this will modify the usage, so new big version will be release.

So can help to give us a pr ?

[hustcc]

@theseushu The commit 4ac9b5d can solve this issue.