Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassicLilithEncoder shall implement Encoder<ILoggingEvent> #16

Closed
paolofulgoni opened this issue Apr 2, 2014 · 6 comments
Closed

ClassicLilithEncoder shall implement Encoder<ILoggingEvent> #16

paolofulgoni opened this issue Apr 2, 2014 · 6 comments

Comments

@paolofulgoni
Copy link

I'm trying to programmatically configure Logback to use a RollingFileAppender. Also I'd like to use ClassicLilithEncoder as encoder.

Given that an Appender can be added to a Logger with the following method

addAppender(Appender<ILoggingEvent> newAppender)

Therefore the type parameter of my RollingFileAppender must be ILoggingEvent.

Unfortunately ClassicLilithEncoder implements Encoder<LoggingEvent>, so I cannot pass it to the setEncoder(Encoder<ILoggingEvent>) of RollingFileAppender<ILoggingEvent>.

@huxi huxi closed this as completed in 97fbc69 Apr 2, 2014
@huxi
Copy link
Owner

huxi commented Apr 2, 2014

Good point. Wasn't aware of this. Thanks!

@paolofulgoni
Copy link
Author

Great, thank you!!!
Will you publish the updated lib to Maven Central?

@huxi
Copy link
Owner

huxi commented Apr 2, 2014

Not sure about the date of the next release. I want to fix another issue before performing it.

@paolofulgoni
Copy link
Author

I understand, I'll check the project's updates.

@huxi
Copy link
Owner

huxi commented Apr 21, 2014

The new version is out.

@paolofulgoni
Copy link
Author

Got it! ClassicLilithEncoder is working fine.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants