Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference error in Documentation #403

Closed
dheerajiiitv opened this issue Dec 23, 2022 · 2 comments
Closed

Reference error in Documentation #403

dheerajiiitv opened this issue Dec 23, 2022 · 2 comments

Comments

@dheerajiiitv
Copy link
Contributor

dheerajiiitv commented Dec 23, 2022 •
edited
Loading

Hey Team,
https://github.com/hwchase17/langchain/blob/master/docs/explanation/combine_docs.md#refine Here as we can see
There is an error in the description of the Refine method. The text describes the Refinemethod as having "Pros" (advantages) that include "Can pull in more relevant context, and may be less lossy than RefineDocumentsChain." However, this makes no sense, as the Refine method is being described, not the RefineDocumentsChain method.
@dheerajiiitv
Copy link
Contributor Author

I am working on this issue @hwchase17 .

@dheerajiiitv dheerajiiitv mentioned this issue Dec 23, 2022
Merged
hwchase17 pushed a commit that referenced this issue Dec 23, 2022
@dheerajiiitv
Fix documentation error langchain explanation of combine_docs.md (#404)
ea3da9a 
This PR is regarding the issue here -
#403
@hwchase17
Copy link
Contributor

thank you @dheerajiiitv !

mikeknoop pushed a commit to zapier/langchain-nla-util that referenced this issue Mar 9, 2023
@dheerajiiitv
Fix documentation error langchain explanation of combine_docs.md (#404)
39461c0 
This PR is regarding the issue here -
langchain-ai/langchain#403
wertycn pushed a commit to wertycn/langchain-zh that referenced this issue Apr 26, 2023
@dheerajiiitv
Fix documentation error langchain explanation of combine_docs.md (#404)
995fd7e 
This PR is regarding the issue here -
langchain-ai/langchain#403
ZinedineDumas added a commit to ZinedineDumas/React-Python that referenced this issue Jul 17, 2023
@ZinedineDumas @dashesy
Fix documentation error langchain explanation of combine_docs.md (#404)
1ae524b 
This PR is regarding the issue here -
langchain-ai/langchain#403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hwchase17 @dheerajiiitv