Bugfix | Fixed bundle controllers to not depend on container if possible

[stloyd]

This PR changes:

• removed dependency on AbstractController in LoginController,
• replaced dependency on parameters in ConnectController in favor of injecting them into __construct()

[XWB]

Not sure about this, Symfony advises that bundles should not rely on autoconfigure / autowire.

[Seldaek]

It does not seem to fix my issue @stloyd:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException:
The "HWI\Bundle\OAuthBundle\Controller\ConnectController::getParameter()" method is missing a parameter bag to work properly. Did you forget to register your controller as a service subscriber? This can be fixed either by using autoconfiguration or by manually wiring a "parameter_bag" in the service locator passed to the controller.

  at vendor/symfony/framework-bundle/Controller/AbstractController.php:68
  at Symfony\Bundle\FrameworkBundle\Controller\AbstractController->getParameter()
     (vendor/hwi/oauth-bundle/Controller/ConnectController.php:157)
  at HWI\Bundle\OAuthBundle\Controller\ConnectController->connectServiceAction()
     (vendor/symfony/http-kernel/HttpKernel.php:158)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor/symfony/http-kernel/HttpKernel.php:80)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor/symfony/http-kernel/Kernel.php:201)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (web/app.php:35)                

[ksom]

@XWB This commit doesn't use autowire or autoconfigure. It adds some explicit dependencies in the service configuration.
To me, it's the way to go.

@Seldaek Yes it's normal, because your issue is located in the ConnectController and this commit concerns the LoginController.

Please merge this, it doesn't solve every issues but it's a step forward.