Add test to CI using FOSUserBundle #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
reviewed
Jul 26, 2021
franmomu
force-pushed
the
add_test_with_fos
branch
3 times, most recently
from
7271575
to
5b1e58a
Compare
franmomu
force-pushed
the
add_test_with_fos
branch
from
c42248f
to
1c83659
Compare
franmomu
force-pushed
the
add_test_with_fos
branch
from
1c83659
to
15bc2f3
Compare
|
@franmomu Merged, thanks! |
|
Thank you for moving this forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, functional tests are executed, it used to failed before #1689, that can be seen in franmomu#2, now it should pass.
Replaces #1750
This job will be removed in
2.0, but it is useful to execute our functional tests in CI instead of skipping them.Needs #1752 and #1751