Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a new coin guide #90

Closed
kruhc opened this issue Oct 8, 2021 · 2 comments
Closed

How to add a new coin guide #90

kruhc opened this issue Oct 8, 2021 · 2 comments

Comments

@kruhc
Copy link
Contributor

kruhc commented Oct 8, 2021

Hello, what is a good practice for adding a new coin? I'm helpless.

I noticed that Bitpanda added XYM to the price ticker, so I:

  • added and entry to Coin.kt: XYM("Symbol", IconTheme(SOLID, ic_xym)),
  • added map entry to COINGECKO in Exchange.kt : "XYM" to "symbol",
  • added XYM coin record to BITPANDA and COINGECKO exchanges in cryptowidgetcoins.json

Before this, I could select XYM price from CoinGecko, now I get No currencies/exchanges found for this coin! warning.

I also noticed in the GenerateSupportedCoins test output that there are more exchanges with XYM, so it is acceptable to add XYM coin record to all of them in the json file?

Thank you!

@kruhc kruhc changed the title How to add a new coin How to add a new coin guide Oct 8, 2021
@hwki
Copy link
Owner

hwki commented Oct 8, 2021

Adding a new coin involves what you did there, adding the entry to Coin.kt and the special case for CoinGecko exchange. Then just run GenerateSupportedCoins to recreate the json file. However, the existing app will still use what it has pulled down from the web unless the last_modified date is newer. I usually update that date after I upload the json file to s3, so I can take care of that part if you want to merge in what you have.

@kruhc
Copy link
Contributor Author

kruhc commented Oct 8, 2021

Great info. Thank you.

@kruhc kruhc closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants